commit 18ac387e6a706019bc5a6c9fadf266eb2b4bf05d Author: Fridolin Somers Date: Mon May 6 12:08:02 2024 +0200 Bug 36787: staticfines.pl add use Koha::DateUtils::output_pref misc/cronjobs/staticfines.pl is calling output_pref() but it is missing from module import : use Koha::DateUtils qw( dt_from_string ); Test but running staticfines.pl Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer commit 6d0d585c14a5943fad77f1f6481f5213cc4f7983 Author: Jonathan Druart Date: Tue May 7 15:46:54 2024 +0200 Bug 36750: Fix Languages vs Language Signed-off-by: Katrin Fischer commit a654faf72e602463fec6ebeda2a4da8ed4938bfc Author: Jonathan Druart Date: Mon May 6 11:55:28 2024 +0200 Bug 36750: Fix aria-label for show more/less links Didn't manage to keep the more_less_labels because of the space in the key names Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 4ffaa07a40a9cb6648779ed8aa0984827e87f7b2 Author: Jonathan Druart Date: Mon May 6 11:38:44 2024 +0200 Bug 36750: Use the same label for Zebra Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 4e8500beb0873aa96e5c33c45b1e4b17030edec1 Author: Jonathan Druart Date: Mon May 6 11:07:13 2024 +0200 Bug 36750: Fix some labels Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 52c46ae8d0c35a4964adf83e55d016c60af28141 Author: Nick Clemens Date: Thu May 2 16:44:36 2024 +0000 Bug 36750: (35138 follow-up) Use same display code for OPAC To test: 1 - In OPAC with ES enabled do a search 2 - Note missing facet labels 3 - Apply patch 4 - They are back! Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 7cc445e95cc7ba5130fc0efbca863f858d4269ee Author: David Nind Date: Tue May 7 05:41:54 2024 +0000 Bug 36796: (follow-up) Fix column descriptions for the statistics table This follow-up to bug 32312 fixes the descriptions for the statistics database columns, used in guided reports. It removes the duplicate statistics section in Koha/Database/Columns.pm so that descriptions are displayed for all columns, as originally intended. It also adds a description for the interface column (a new column added after the original patch was pushed). Test plan: 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that some columns have descriptions and some don't: Statistics date and time / statistics.datetime Library / statistics.branch Value / statistics.value Type / statistics.type Item number / statistics.itemnumber Item type / statistics.itemtype statistics.other statistics.location Borrower number / statistics.borrowernumber statistics.ccode statistics.categorycode statistics.interface 5. Apply the patch. 6. Restart all the things (restart_all). 7. Repeat steps 1 to 4. 8. Scroll down to the statistics table section again and note that all columns now have descriptions: Statistics date and time / statistics.datetime Library / statistics.branch Value / statistics.value Transaction type / statistics.type SIP mode / statistics.other Item number / statistics.itemnumber Koha item type / statistics.itemtype Shelving location / statistics.location Borrower number / statistics.borrowernumber Collection / statistics.ccode Patron category / statistics.categorycode Interface / statistics.interface 9. Sign off :D Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit a464e20091e0662bed82bfe308af69c8710614aa Author: Martin Renvoize Date: Tue May 7 13:07:53 2024 +0100 Bug 36612: (QA follow-up) Add 'source' to public_read_list This patch adds the required 'source' field to the public_read_list for tickets. Signed-off-by: Katrin Fischer commit 14675bea5616c934e0588993b3f4aabaebd3f736 Author: Nick Clemens Date: Tue May 7 12:35:04 2024 +0000 Bug 30579: (follow-up) Style selections as buttons Signed-off-by: Katrin Fischer commit e2c4b292d4b364a9a847b20b63183b14b3e4e3fa Author: Nick Clemens Date: Tue May 7 12:24:24 2024 +0000 Bug 30579: (follow-up) Standardize labels: This patch changes the heading for specific item holds, so the three options are now: Hold next available item Hold next available item from an item group Hold a specific item Signed-off-by: Katrin Fischer commit fe4be8be6e82dfb20e66dc1d5f3ce8e70ce9f041 Author: Nick Clemens Date: Tue May 7 12:01:33 2024 +0000 Bug 30579: (follow-up) Fix rebase of multi holds form and add CSRF This patch restores missing elemtns to multi-hold form and adds CSRF variables Signed-off-by: Katrin Fischer commit 2f70239201cd1d3c93cdd9557f9752bb88c7bf55 Author: Nick Clemens Date: Thu May 2 16:05:35 2024 +0000 Bug 30579: Fix rebase issue Signed-off-by: Katrin Fischer commit c583acec24c9d0a1ab04af9fef041f58dc232ac7 Author: Nick Clemens Date: Fri Mar 15 18:03:10 2024 +0000 Bug 30579: (follow-up) Remove unnecessary nested form elements Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 0209573f169029165a5c2e159e523a4296169180 Author: Emily Lamancusa Date: Thu Oct 26 13:00:10 2023 -0400 Bug 30579: (follow-up) fix button id Signed-off-by: Emily Lamancusa Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 9caea3fcfcea694b41f9cf2dc79cf78d3f3560e2 Author: Nick Clemens Date: Wed Oct 25 12:13:49 2023 +0000 Bug 30579: (follow-up) Add required label and warning when hold levels required Signed-off-by: Emily Lamancusa Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 4686f5f0ff9f79fbad515a5bb85a92d0e04089d4 Author: Nick Clemens Date: Wed Oct 25 11:40:04 2023 +0000 Bug 30579: (follow-up) Use same conditions on item groups place hold button as on other options Signed-off-by: Emily Lamancusa Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit e40bbac24f13e7f6ba83e3b765a0e0f5acebe94c Author: Nick Clemens Date: Mon Aug 28 14:42:49 2023 +0000 Bug 30579: (follow-up) Add fieldsets and style disabled elements This patch surrounds each section with a fieldset which allow enabling/disabling all the elements in one go. CSS is added to make it clear which fields are disabled. Button for item specific is moved form the multi-hold section Javascript is simplified to use the new fieldsets To test: 1 - Repeate test plan on earlier commit 2 - Additionally, search and select multiple records and place hold 3 - Confirm multi-hold placing works :-) Signed-off-by: Emily Lamancusa Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit b44bfbdaf200a5169398c9ff10a7552de0797c4a Author: Nick Clemens Date: Mon Aug 28 12:26:44 2023 +0000 Bug 30579: Remove doubled notes field Signed-off-by: Emily Lamancusa Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 00b2f755e7c49e0c6845f21a52d4badbde2a13d9 Author: Jonathan Druart Date: Tue May 23 11:36:43 2023 +0200 Bug 30579: Add missing for attribute on label Signed-off-by: Emily Lamancusa Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit bc172982f8e296a6c923601ca553c116d8fe0d16 Author: Nick Clemens Date: Fri Sep 23 15:06:05 2022 +0000 Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Click the 'Holds' tab and search for/select a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Check 'Hold next available item from an item group' 10 - Do not select an item group 11 - Click 'Place hold' and confirm you are notified of need to select an item group NOTE: if you are overrirding you may also have an alert that the items cannot normally be put on hold 12 - Click 'Place hold on a specific item' - but do not select an item 13 - Click place hold and confirm there is an alert and you cannot continue 14 - Click 'Hold next available item' and place hold 15 - Hold is successfully placed 16 - Place another hold for the same patron 17 - Only the 'Hold next available item' form is enabled 18 - Confirm you cannot switch hold type 19 - Place hold 20 - Select a new patron and place an item group hold 21 - Select the same patron and place another hold - you are forced to place an item group hold 22 - Select a new patron and place a hold on a specific item 23 - Place a second hold, confirm you can only place it on a specific item Signed-off-by: hinemoea Signed-off-by: Sam Lau Signed-off-by: Emily Lamancusa Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 79d30205943dd3adeabd267bc729a63e69c0be30 Author: Katrin Fischer Date: Tue May 7 13:16:07 2024 +0000 Bug 36396: DBRev 23.12.00.049 Signed-off-by: Katrin Fischer commit 98a1f1750177251d743162a7ace9fc6767867abf Author: Jonathan Druart Date: Tue May 7 12:41:39 2024 +0200 Bug 36396: Add tests Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 98e6ddd4a3042a0a419a0f0d0d0c7a5abafac0bd Author: Jonathan Druart Date: Fri Mar 22 14:37:22 2024 +0100 Bug 36396: (follow-up) Prevent link to av for 'specials' Signed-off-by: Lukas Koszyk Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 5561383a9ffe0f294b756ab3a56754901c34ceae Author: Jonathan Druart Date: Fri Mar 22 10:04:08 2024 +0100 Bug 36396: Export/import the yaml config Test plan: Export the ES fields/mappings using misc/search_tools/export_elasticsearch_mappings.pl > mappings.yaml Copy this file to admin/searchengine/elasticsearch/mappings.yaml Reset the mapping from the UI Notice that the links to the AV categories have been preserved Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Lukas Koszyk Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 621ad21a7aea74afddc06f73ae86f477077becb5 Author: Jonathan Druart Date: Fri Mar 22 09:23:19 2024 +0100 Bug 36396: UI - OPAC Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Lukas Koszyk Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 4941197a4b4e003ca7f0d53597d7a11031cc3e5c Author: Jonathan Druart Date: Fri Mar 22 09:29:45 2024 +0100 Bug 36396: Prevent link to av for 'specials' See previous commit message, 'QA' part. We do not support the "specials" categories. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Lukas Koszyk Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 901f550a47bce01f6f4cd503ff0abb2417ba44e9 Author: Jonathan Druart Date: Thu Mar 21 16:48:56 2024 +0100 Bug 36396: Link facet with authorised value category - ES This new feature adds the ability to link an ES facet to an authorised value category, in order to display a description instead of the code. Test plan: 1. Go to the ES mapping admin page 2. Notice the new "Authorized value category" column in the facets config table 3. Create a new facet that is linked to a search field containing values from an authorised value category. Pick this category in the list 4. Save 5. Reindex 6. Notice that the descriptions are now displayed (staff and OPAC) in the search result page. QA: See the related bug report for possible improvements. It's not easy at all to deal with the "specials" here, a lot of changes must be done in how we fetch/cache the AVs. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Lukas Koszyk Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 58d097d2aa3884162bbc4acaf6f14c3beec9b8cb Author: Jonathan Druart Date: Thu Mar 21 15:51:44 2024 +0100 Bug 36396: DBIC schema changes Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Lukas Koszyk Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit a3887fe12af6979bef92be3025fbaabc09e6f1e0 Author: Jonathan Druart Date: Thu Mar 21 15:45:11 2024 +0100 Bug 36396: DB changes Add the new DB column search_field.authorised_value_category Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Lukas Koszyk Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 09734c1c1195de97d6a8959de94d00689e926c3f Author: Katrin Fischer Date: Tue May 7 13:11:23 2024 +0000 Bug 33134: DBRev 23.12.00.048 Signed-off-by: Katrin Fischer commit 4053893e4f282456dbc4bdb53f14b8b4a482b71c Author: Janusz Kaczmarek Date: Fri Mar 3 23:15:51 2023 +0100 Bug 33134: Add some 76 missing languages When languages come into facets in ES, Koha should know the names for the codes used records. Otherwise the three-letters language code is being displayed in the facet instead of name. Koha now knows about 77 languages, many are still missing. The most missed 76 languages, in order of occurrences in my data sets, are (MARC 21 codes): grc, syr, chu, cop, arc, ang, epo, syc, gez, sla, san, csb, akk, gmh, egy, wen, gle, fro, rom, mac, mal, uga, mis, sem, sux, pli, bos, che, dum, kaz, tib, enm, frm, mlt, got, nds, ira, lin, uzb, ave, cho, jrb, bnt, pal, tut, goh, hsb, inc, mlg, roa, cel, sam, bem, fur, gem, hit, lad, nah, ota, peo, pro, tat, wel, yor, bra, den, hau, her, kas, mga, myn, nya, pra, que, tir, tuk. Plus: gwi, dgr, chp asked in bug 23693. Here, I do not put language codes which are extremely rare in my data sets. Subtags and names for language_subtag_registry are taken from https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry, English names for language_descriptions.description - from https://www.loc.gov/marc/languages/language_code.html, and Polish names - from https://przepisy.bn.org.pl/aneksy#25-kody-jezykow---marc-21. Test plan: ========== 1. Hava a ES installation with reasonable number of records, with a variety of languages in 008/35-39 not present in Koha (you can modify your record with codes from the list above). Set FacetMaxCount to a high number (like 500 or so, dependiing on the size of your data set). 2. Do a search, like '*a*'. 3. Controll the content of the Language faset -- you should see some bare codes instead of language names. 4. Apply the patch -- update the database. 5. Perform the same search. 6. You should see the names in place of the codes. 7. Optionally, you can activate the Polish translation and you should be able to see Polish names for the added languages. Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 2a20cbb94a8e4d54279d80c136e09a29361bfcfd Author: Thomas Klausner Date: Mon May 6 12:39:35 2024 +0000 Bug 36151: Update leaflet.js Koha currently comes with leaflet.js 1.0.3 which is quite old (2017). For GeoSearch (Bug 31652) we need a more current leaflet.js, so this patch updates leaflet.js to the current version 1.9.4 Test plan: * Go to staff /cgi-bin/koha/admin/usage_statistics.pl where you see a map and can set the location of the library by clicking on the map. * Apply the patch * Again, go to staff /cgi-bin/koha/admin/usage_statistics.pl * Do a complete reload of the page * It should still work: * Display the location as a pin * Set a new location There was no code change necessary besides downloading the current version of leaflet.js and updating the about-page Sponsored-by: Geosphere Austria Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 5ddd89cbb29fec150e65a99ef99e84269a84b781 Author: Katrin Fischer Date: Tue May 7 12:58:55 2024 +0000 Bug 35169: DBRev 23.12.00.047 Signed-off-by: Katrin Fischer commit 871915219b3348ebf5c76f7db21941afd6a45137 Author: Katrin Fischer Date: Tue May 7 12:57:52 2024 +0000 Bug 35169: (follow-up) Fix sequence and patron categories in sysprefs.sql Signed-off-by: Katrin Fischer commit 7dd3fc3cef81ce34fb7f8b012a49ecb2557b4614 Author: Martin Renvoize Date: Tue May 7 11:52:42 2024 +0100 Bug 35169: (QA follow-up) Fix spelling and preference name Update the preference name from 'Borrower' to 'Patron' and correct spelling of receive. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit ab438e70230cd6885c58a9b7d3cfe2b8262260de Author: Kyle M Hall Date: Fri May 3 14:07:44 2024 +0000 Bug 35169: (QA follow-up) Fix up syspref language and group them together The language used in the syspref preferences was a bit confusing. Also, it makes sense to keep these two together on the page as they are intrinsically linked. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit a03b3e5fe2a6b34ab13ab0d0e19b5fa65dcd2be9 Author: Lucas Gass Date: Sat Mar 9 17:53:13 2024 +0000 Bug 35169: (follow-up) perltidy Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 0ebc5a78d9ceba0d7f7cf6ab28fd9d2faa566c9b Author: Matthias Le Gac Date: Fri Mar 1 14:17:20 2024 -0500 Bug 35169: Resolve the override situations Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit e8fef64cf5d0856ffbcee29da8b125aa59adc9ff Author: Matthias Le Gac Date: Fri Mar 1 08:53:43 2024 -0500 Bug 35169: update DBupdate file Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit fcd59d771294c111ff1ea7cca3dc54b4bf2166fd Author: Matthias Le Gac Date: Thu Feb 29 12:08:00 2024 -0500 Bug 35169: update sysprefs.sql Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 41d24731981cd472b017cb8e867d9708b650d1fb Author: Matthias Le Gac Date: Thu Feb 22 15:33:25 2024 -0500 Bug 35169: add bug_35169.pl for DB Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 7c9a7fe7ff4ffb0fbc6e421c0d68d11e0e4fb58e Author: Matthias Le Gac Date: Thu Feb 22 14:46:22 2024 -0500 Bug 35169: Make long overdue borrower category options configurable in interface Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 5e06fd00cef16f4d8e90d7a236f45868b1de2c9d Author: Lucas Gass Date: Mon Apr 29 20:39:08 2024 +0000 Bug 36709: Add confirm flag to update_localuse_from_statistics.pl script To test: 1. APPLY PATCH and restart all 2. Run the update_localuse_from_statistics.pl script without a confirm flag, nothing happens. 3. Run the script and add the --confirm flag, stuff happens. Signed-off-by: Matt Blenkinsop Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 67b3cbd438f0cee378cfa5236f2673ab6ea32f33 Author: Janusz Kaczmarek Date: Tue Apr 30 10:18:12 2024 +0000 Bug 36730: (Bug 35428 follow-up) po files (sometimes) fail to update Under some circumstances (e.g. non-standard disk latency) po files fail to be generated. The output from the gulp po:update --lang xx-XX task is than like this: [10:01:39] 'po_update_staff' errored after 6.41 s [10:01:39] Error: ENOENT: no such file or directory, open '/tmp/koha-5WCc9s/Koha-staff-prog.pot' This is due to the time dependencies inside the function flush (callback) (in the function xgettext) in gulpfile.js. It happens that the /tmp/koha-NNNNNN folder gets deleted before the asynchronous callback function called by fs.readFile is completed. The callback should copy the content of the .pot file from /tmp/koha- to its final destination, while, in parallel in fact, the folder inside /tmp is being removed. This creates a race condition. Test plan: ========== Hard to reproduce. But the race condition found in the code should be obvious. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 7f22156b8fea3766f893d28fc17ebe8561d5e7cc Author: Marcel de Rooy Date: Fri May 3 09:07:17 2024 +0000 Bug 34972: (QA follow-up) Remove second transfer from Circulation.t Removing the manual transfer and rightaway doing the Reserve transfer. One test description was misleading too. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 87c1759dd789cb2a91bff8e6609847811c05f984 Author: Marcel de Rooy Date: Fri May 3 08:07:24 2024 +0000 Bug 34972: (QA follow-up) Remove some ModReserveCancelAll imports Not used? Dont import. Which actually only leaves circ/waitingreserves.pl as the only 'real' caller. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit dc00e55a322c2c5279e4c42d516125d4e98cff4e Author: Emily Lamancusa Date: Tue Mar 19 14:14:27 2024 -0400 Bug 34972: Remove GetOtherReserves GetOtherReserves attempts to set the waiting/transit status for the next hold on the list when applicable, but in practice it either leaves the hold state unchanged, or sets the itemnumber without setting the found status (erroneously converting bib-level holds to item-level holds). The latter situation only occurs when the user has been prompted to confirm, cancel, or revert the hold, and is able to ignore the prompt. In those situations, the hold's state should not change. GetOtherReserves does not need to change the hold state, and it does not do so correctly. Besides that, it does not do much other than call CheckReserves, and is only used in 3 places. This patch removes GetOtherReserves, and refactors returns.pl and C4::Reserves::ModReserveCancelAll to call CheckReserves directly instead. To test: 1. Place 2 bib-level holds for 2 different patrons (Patron A and Patron B) on the same record, both for pickup at the logged-in library 2. Check in an item from that record to fill Patron A's hold 3. Set the hold's expiration date to yesterday by accessing the database in the command line: - In a ktd shell prompt, open the db client with koha-mysql kohadev - UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY) WHERE borrowernumber = 4. Go to Circulation > Holds Awaiting Pickup, and find the hold in the "holds waiting past their expiration date" tab 5. Click the "Cancel hold" button in the Actions column next to the hold (do not check in the book) 6. Return to the bib record and look at Patron B's hold --> Note that Patron B's hold is now an item-level hold and does not have a waiting status 7. Cancel Patron B's hold 8. Place 2 new holds on the record: one for Patron A at the logged-in library, and one for Patron B at a different library 9. Check in an item to fill Patron A's hold 10. Repeat steps 3-5 to expire and cancel Patron A's hold 11. Return to the Holds tab of the bib record and look at Patron B's hold --> Note that Patron B's hold is now an item-level hold, and there is no "Revert transit status" button 12. Place 2 bib-level holds for 2 different patrons (Patron A and Patron B) on the same record, both for pickup at the logged-in library 13. Check in an item from that record to fill Patron A's hold 14. Check in the same item again. A modal will pop up, saying that the hold is already waiting 15. In the modal, choose a cancellation reason and click "Cancel hold" --> A new modal will pop up to fill Patron B's hold 16. Click "Ignore" on the modal for Patron B's hold 17. Return to the bib record and look at Patron B's hold --> Note that Patron B's hold is now an item-level hold and does not have a waiting status 18. Apply patch 19. Repeat steps 1-6 --> Note that Patron B's hold is still a bib-level/"next available" hold 20. Repeat steps 7-11 --> Note that Patron B's hold is still a bib-level/"next available" hold 21. Repeat steps 12-17 --> Note that Patron B's hold is still a bib-level/"next available" hold Make sure correct behavior is unchanged: 22. Cancel Patron B's hold 23. Place 2 new holds on the record: one for Patron A at the logged-in library, and one for Patron B at a different library 24. Check in an item from that record to fill Patron A's hold 25. Check in the same item again. A modal will pop up, saying that the hold is already waiting 26. In the modal, choose a cancellation reason and click "Cancel hold" --> A new modal will pop up to fill Patron B's hold 27. Click "Print slip, transfer, and confirm" on the modal for Patron B's hold --> Confirm that the information on the slip is correct --> Confirm that the hold is correctly put in transit 22. Set HoldsAutoFill and HoldsAutoFillPrintSlip to "Do" 23. Place a bib-level hold for the logged-in library 24. Check in an item from that bib --> Confirm the information on the slip is correct --> Confirm the hold is correctly assigned and set to waiting 25. Place a bib-level hold for a different library 26. Check in an item from that bib --> Confirm the information on the slip is correct --> Confirm the hold is correctly put in transit 27. Change the logged-in branch to match the hold pickup location 28. Check the item in --> Confirm the information on the slip is correct --> Confirm the hold is correctly assigned and set to waiting 29. Repeat steps 22-26 --> Confirm a correct hold slip pops up for Patron B's hold --> Confirm that Patron B's hold is correctly put in transit 30. Cancel Patron B's hold 31. Place 2 bib-level holds for 2 different patrons (Patron A and Patron B) on the same record, both for pickup at the logged-in library 33. Repeat steps 24-26 --> Confirm a correct hold slip pops up for Patron B's hold --> Confirm Patron B's hold is correctly set to Waiting 34. Prove t/db_dependent/Circulation.t 35. Prove t/db_dependent/Koha/Holds.t --> Tests pass Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit d71f5272021b54849e5854d3a7b8ecb1f30d9414 Author: Emily Lamancusa Date: Wed Apr 3 16:24:38 2024 -0400 Bug 34972: Add tests for ModReservesCancelAll To test: 1. Apply this patch only 2. prove t/db_dependent/Koha/Holds.t --> Tests pass 3. Apply the other patch 4. prove t/db_dependent/Koha/Holds.test --> Tests still pass Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 8d9ccd6fc371877fbd4d016ee3bc1de54721787e Author: Janusz Kaczmarek Date: Mon May 6 12:06:22 2024 +0000 Bug 36792: Limit POSIX imports A Marcel's QA patch to Bug 36552 added use POSIX; in two spots. In https://metacpan.org/pod/POSIX we read: CAVEATS Everything is exported by default (with a handful of exceptions). This is an unfortunate backwards compatibility feature and its use is strongly discouraged. You should either prevent the exporting (by saying use POSIX ();, as usual) and then use fully qualified names (e.g. POSIX::SEEK_END), or give an explicit import list. If you do neither and opt for the default (as in use POSIX;), you will import hundreds and hundreds of symbols into your namespace. This patch fixes this. No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit ff183612043b8f37d74fbbd9c306a54c48329d99 Author: Jonathan Druart Date: Mon May 6 12:58:33 2024 +0200 Bug 36790: List table columns for 230600052 queries We must list the columns, or the db rev will fail when a new column is added. It happened here when 33478 added 'style' Also remove id and dates To test: 1. On current main, run: $ ktd --shell k$ perl /kohadevbox/misc4dev/run_tests.pl --koha-dir=. --run-db-upgrade-only => FAIL: Tests explode for DB query issues 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer